react_refresh: Don't visit arrow function nodes #37
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since atoms created in a function context are new atoms, there's nothing in the arrow function sub-tree that we should transform. The default behavior seems to be to visit everything, whereas an empty impl stops the walk. Another driveby fix: store previous `top_level` in `visit_mut_stmts` instead of always resetting it to `true`. I don't have a failing test for this (so it might be fine), but it's a pattern that's explicitly called out in the docs [0]. [0]: https://swc.rs/docs/plugin/ecmascript/cheatsheet#make-your-handlers-stateless Fixes pmndrs#36
|
As it turns out, this also fixes #34 |
meyer
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since atoms created in a function context are new atoms, there's nothing in the arrow function sub-tree that we should transform. The default behavior seems to be to visit everything, whereas an empty impl stops the walk.
Another driveby fix: store previous
top_levelinvisit_mut_stmtsinstead of always resetting it totrue. I don't have a failing test for this (so it might be fine), but it's a pattern that's explicitly called out in the docs 0.Fixes #36